Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov addin runner to support official codecov binary #219

Closed
AdmiringWorm opened this issue Dec 1, 2021 · 12 comments · Fixed by #243
Closed

Update codecov addin runner to support official codecov binary #219

AdmiringWorm opened this issue Dec 1, 2021 · 12 comments · Fixed by #243
Assignees
Milestone

Comments

@AdmiringWorm
Copy link
Member

The codecov team have deprecated the use of all community maintained applications, the community maintained applications will stop working in Januarry/February, as such this addin needs to be updated to ensure it is compatible with the official binary.

It is uncertain at this time if it will be a breaking change or not.

@AdmiringWorm AdmiringWorm added this to the 1.1.0 milestone Dec 1, 2021
@gep13
Copy link
Member

gep13 commented Jan 31, 2022

@AdmiringWorm what are your plans for sourcing the new official binary?

From what we can see, these can be found here:

https://uploader.codecov.io/

Should the Cake.Codecov addin source/download this binary depending on where it is being executed, or did you have a different plan for this?

Getting this out the door is obviously required before a new release of Cake.Recipe is made, since as of tomorrow, its support for Codecov will no longer work 😢

@AdmiringWorm
Copy link
Member Author

Honestly, my only plan is just for those that want to use it to ensure they have it already on the system, and only update this addin to support whatever arguments are available in the uploader they provide.

@gep13
Copy link
Member

gep13 commented Feb 1, 2022

@AdmiringWorm I guess this makes sense. Addins do tend not to actually download any files, so perhaps that becomes the responsibility of the parent Cake script, or external process to ensure that it is on disk, somewhere, that the addin can find it.

@nils-a
Copy link
Contributor

nils-a commented Feb 1, 2022

As an example to the contrary, Cake.Gradle has a BootstrapGradle() alias that will download and provide the gradle wrapper 😄

@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Feb 1, 2022

@nils-a or embed and extract the file as I do in Cake.Warp.

EDIT: I would rather embed the file, than have the ability to download it.

@gep13
Copy link
Member

gep13 commented Feb 1, 2022

@AdmiringWorm I haven't checked, but does the license of the codecov uploader allow for redistribution?

@nils-a
Copy link
Contributor

nils-a commented Feb 1, 2022

but does the license of the codecov uploader allow for redistribution?

It's licensed under the apache license, so that should not be an issue.

But, when we embed, there's the point of keeping up-to-date. It seems they release quite often.

@nils-a
Copy link
Contributor

nils-a commented Mar 22, 2022

@AdmiringWorm, @gep13 I have created https://www.nuget.org/packages/CodecovUploader/ which bundles the official tool from Codecov in a NuGet. This way, the packages will be auto-updated, and we can keep the (IMHO good) separation of "tool" and "addin".

@AdmiringWorm
Copy link
Member Author

@nils-a that is awesome, thank you for doing that.

It do look like however that your CI builds fail, and caused the package to be out of date

@AdmiringWorm AdmiringWorm self-assigned this May 15, 2022
@gep13
Copy link
Member

gep13 commented May 15, 2022

@AdmiringWorm @nils-a seems like the index URL has changed, no idea why, but the information your script requires can be found here (I think):

https://api.nuget.org/v3/registration5-semver1/codecovuploader/index.json

Rather than at:

https://api.nuget.org/v3-flatcontainer/CodecovUploader/index.json

@nils-a
Copy link
Contributor

nils-a commented May 15, 2022

@AdmiringWorm Thanks for the heads-up. I kind of saw that, but didn't get around to fix it.

Thanks, @gep13, for figuring it out. 🙇‍♂️

The package has been updated and CI is running again. 🚀

@AdmiringWorm AdmiringWorm changed the title Change addin to support new official binary Update codecov addin runner to support official codecov binary May 2, 2024
@cake-contrib-bot
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release can be downloaded from:

Your friendly GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants