New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codecov addin runner to support official codecov binary #219
Comments
@AdmiringWorm what are your plans for sourcing the new official binary? From what we can see, these can be found here: Should the Cake.Codecov addin source/download this binary depending on where it is being executed, or did you have a different plan for this? Getting this out the door is obviously required before a new release of Cake.Recipe is made, since as of tomorrow, its support for Codecov will no longer work 😢 |
Honestly, my only plan is just for those that want to use it to ensure they have it already on the system, and only update this addin to support whatever arguments are available in the uploader they provide. |
@AdmiringWorm I guess this makes sense. Addins do tend not to actually download any files, so perhaps that becomes the responsibility of the parent Cake script, or external process to ensure that it is on disk, somewhere, that the addin can find it. |
As an example to the contrary, Cake.Gradle has a |
@nils-a or embed and extract the file as I do in Cake.Warp. EDIT: I would rather embed the file, than have the ability to download it. |
@AdmiringWorm I haven't checked, but does the license of the codecov uploader allow for redistribution? |
It's licensed under the apache license, so that should not be an issue. But, when we embed, there's the point of keeping up-to-date. It seems they release quite often. |
@AdmiringWorm, @gep13 I have created https://www.nuget.org/packages/CodecovUploader/ which bundles the official tool from Codecov in a NuGet. This way, the packages will be auto-updated, and we can keep the (IMHO good) separation of "tool" and "addin". |
@nils-a that is awesome, thank you for doing that. It do look like however that your CI builds fail, and caused the package to be out of date |
@AdmiringWorm @nils-a seems like the index URL has changed, no idea why, but the information your script requires can be found here (I think): https://api.nuget.org/v3/registration5-semver1/codecovuploader/index.json Rather than at: https://api.nuget.org/v3-flatcontainer/CodecovUploader/index.json |
@AdmiringWorm Thanks for the heads-up. I kind of saw that, but didn't get around to fix it. Thanks, @gep13, for figuring it out. 🙇♂️ The package has been updated and CI is running again. 🚀 |
🎉 This issue has been resolved in version 1.1.0 🎉 The release can be downloaded from:
Your friendly GitReleaseManager bot 📦🚀 |
The codecov team have deprecated the use of all community maintained applications, the community maintained applications will stop working in Januarry/February, as such this addin needs to be updated to ensure it is compatible with the official binary.
It is uncertain at this time if it will be a breaking change or not.
The text was updated successfully, but these errors were encountered: