Update to Cake.Issues 0.3.0-beta.4

cake-contrib · Jun 3, 2018 · ba8b88b · ba8b88b
1 parent 8671ea3
commit ba8b88b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 31 deletions.
diff --git a/src/Cake.Issues.MsBuild.Tests/Cake.Issues.MsBuild.Tests.csproj b/src/Cake.Issues.MsBuild.Tests/Cake.Issues.MsBuild.Tests.csproj
@@ -34,8 +34,8 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.2" />
     <PackageReference Include="Cake.Core" Version="0.28.0" />
     <PackageReference Include="Cake.Testing" Version="0.28.0" />
-    <PackageReference Include="Cake.Issues" Version="0.3.0-beta0002" />
-    <PackageReference Include="Cake.Issues.Testing" Version="0.3.0-beta0002" />
+    <PackageReference Include="Cake.Issues" Version="0.3.0-beta0004" />
+    <PackageReference Include="Cake.Issues.Testing" Version="0.3.0-beta0004" />
     <PackageReference Include="Shouldly" Version="3.0.0" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.0.2" />
     <PackageReference Include="xunit" Version="2.3.1" />

diff --git a/src/Cake.Issues.MsBuild/Cake.Issues.MsBuild.csproj b/src/Cake.Issues.MsBuild/Cake.Issues.MsBuild.csproj
@@ -25,7 +25,7 @@
 
   <ItemGroup>
     <PackageReference Include="Cake.Core" Version="0.28.0" />
-    <PackageReference Include="Cake.Issues" Version="0.3.0-beta0002" />
+    <PackageReference Include="Cake.Issues" Version="0.3.0-beta0004" />
     <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.0" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.0.2" />
   </ItemGroup>

diff --git a/src/Cake.Issues.MsBuild/XmlFileLoggerFormat.cs b/src/Cake.Issues.MsBuild/XmlFileLoggerFormat.cs
@@ -64,36 +64,13 @@ public XmlFileLoggerFormat(ICakeLog log)
                 }
 
                 // Build issue.
-                var issueBuilder =
+                result.Add(
                     IssueBuilder
                         .NewIssue(warning.Value, issueProvider)
-                        .WithPriority(IssuePriority.Warning);
-
-                if (!string.IsNullOrWhiteSpace(fileName))
-                {
-                    if (line.HasValue)
-                    {
-                        issueBuilder = issueBuilder.InFile(fileName, line.Value);
-                    }
-                    else
-                    {
-                        issueBuilder = issueBuilder.InFile(fileName);
-                    }
-                }
-
-                if (!string.IsNullOrWhiteSpace(rule))
-                {
-                    if (ruleUrl != null)
-                    {
-                        issueBuilder = issueBuilder.OfRule(rule, ruleUrl);
-                    }
-                    else
-                    {
-                        issueBuilder = issueBuilder.OfRule(rule);
-                    }
-                }
-
-                result.Add(issueBuilder.Create());
+                        .WithPriority(IssuePriority.Warning)
+                        .InFile(fileName, line)
+                        .OfRule(rule, ruleUrl)
+                        .Create());
             }
 
             return result;