Merge branch 'release/1.0.0'

cake-contrib · Jul 28, 2021 · 73787c9 · 73787c9
2 parents bdec09e + 052a18e
commit 73787c9
Show file tree

Hide file tree

Showing 9 changed files with 32 additions and 22 deletions.
diff --git a/docs/examples/appveyor-messages.png → docs/appveyor-messages.png b/docs/examples/appveyor-messages.png → docs/appveyor-messages.png
diff --git a/docs/examples/write-messages.md b/docs/examples/write-messages.md
@@ -41,6 +41,6 @@ Task("ReportIssuesToAppVeyor").Does(() =>
 
 The output will look similar to this:
 
-![AppVeyor messages](appveyor-messages.png "AppVeyor messages")
+![AppVeyor messages](../appveyor-messages.png "AppVeyor messages")
 
 [AppVeyorBuilds]: ../../../../api/Cake.Issues.PullRequests.AppVeyor/AppVeyorBuildsAliases/
diff --git a/docs/features.md b/docs/features.md
@@ -3,7 +3,9 @@ Order: 20
 Title: Features
 Description: Features of the Cake.Issues.PullRequests.AppVeyor addin.
 ---
-The [Cake.Issues.PullRequests.AppVeyor addin] provides the following features.
+The [Cake.Issues.PullRequests.AppVeyor addin] reports issues as messages to AppVeyor builds.
+
+![AppVeyor messages](appveyor-messages.png "AppVeyor messages")
 
 :::{.alert .alert-info}
 There's a [demo repository] available which you can fork and to which you can create pull requests to test the integration functionality.
@@ -12,6 +14,8 @@ There's a [demo repository] available which you can fork and to which you can cr
 # Basic features
 
 * Reports issues as messages to AppVeyor builds.
+* Messages can be written as comment to GitHub pull requests.
+  See [GitHub pull request integration] for an example.
 
 # Supported capabilities
 
@@ -24,4 +28,5 @@ The [Cake.Issues.PullRequests.AppVeyor addin] doesn't support any additional cap
 | <span class="glyphicon glyphicon-remove" style="color:red"></span> | Filtering by modified files    |                                |
 
 [demo repository]: https://github.com/pascalberger/Cake.Issues-Demo
-[Cake.Issues.PullRequests.AppVeyor addin]: https://www.nuget.org/packages/Cake.Issues.PullRequests.AppVeyor
+[Cake.Issues.PullRequests.AppVeyor addin]: https://www.nuget.org/packages/Cake.Issues.PullRequests.AppVeyor
+[GitHub pull request integration]: ./examples/github-pullrequest-integration
diff --git a/nuspec/nuget/Cake.Issues.PullRequests.AppVeyor.nuspec b/nuspec/nuget/Cake.Issues.PullRequests.AppVeyor.nuspec
@@ -8,21 +8,21 @@
     <owners>pascalberger, cake-contrib</owners>
     <summary>AppVeyor support for the Cake.Issues addin for Cake Build Automation System</summary>
     <description>
-      AppVeyor support for the Cake.Issues addin for Cake allows you to write found issues as message to AppVeyor builds.
+AppVeyor support for the Cake.Issues addin for Cake allows you to write found issues as message to AppVeyor builds.
 
-      This addin provides the aliases for writing to AppVeyor builds.
-      It also requires the core Cake.Issues and Cake.Issues.PullRequests addins and one or more issue providers.
+This addin provides the aliases for writing to AppVeyor builds.
+It also requires the core Cake.Issues and Cake.Issues.PullRequests addins and one or more issue providers.
 
-      See the Project Site for an overview of the whole ecosystem of addins for working with issues in Cake scripts.
+See the Project Site for an overview of the whole ecosystem of addins for working with issues in Cake scripts.
     </description>
     <license type="expression">MIT</license>
     <projectUrl>https://cakeissues.net</projectUrl>
     <icon>icon.png</icon>
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <repository type="git" url="https://github.com/cake-contrib/Cake.Issues.PullRequests.AppVeyor.git"/>
     <copyright>Copyright © Pascal Berger</copyright>
-    <tags>Cake Script Cake-Issues Cake-PullRequestSystem Issues PullRequest AppVeyor</tags>
-    <releaseNotes>https://github.com/cake-contrib/Cake.Issues.PullRequests.AppVeyor/releases/tag/0.9.0</releaseNotes>
+    <tags>cake cake-addin cake-issues cake-pullrequestsystem issues pullrequest buildserver appveyor</tags>
+    <releaseNotes>https://github.com/cake-contrib/Cake.Issues.PullRequests.AppVeyor/releases/tag/1.0.0</releaseNotes>
   </metadata>
   <files>
     <file src="..\..\..\..\nuspec\nuget\icon.png" target="" />

diff --git a/nuspec/nuget/icon.png b/nuspec/nuget/icon.png
diff --git a/recipe.cake b/recipe.cake
@@ -11,6 +11,7 @@ BuildParameters.SetParameters(
     repositoryName: "Cake.Issues.PullRequests.AppVeyor",
     appVeyorAccountName: "cakecontrib",
     shouldGenerateDocumentation: false,
+    shouldPublishMyGet: false,
     shouldRunCodecov: true,
     shouldRunGitVersion: true);
 
@@ -19,7 +20,7 @@ BuildParameters.PrintParameters(Context);
 ToolSettings.SetToolSettings(
     context: Context,
     dupFinderExcludePattern: new string[] { BuildParameters.RootDirectoryPath + "/src/Cake.Issues.PullRequests.AppVeyor.Tests/*.cs" },
-    testCoverageFilter: "+[*]* -[xunit.*]* -[Cake.Core]* -[Cake.Testing]* -[*.Tests]* -[Shouldly]* -[Cake.Issues]* -[Cake.Issues.Testing]* -[Cake.Issues.PullRequests]*",
+    testCoverageFilter: "+[*]* -[xunit.*]* -[Cake.Core]* -[Cake.Testing]* -[*.Tests]* -[Cake.Issues]* -[Cake.Issues.Testing]* -[Cake.Issues.PullRequests]* -[Shouldly]* -[DiffEngine]* -[EmptyFiles]*",
     testCoverageExcludeByAttribute: "*.ExcludeFromCodeCoverage*",
     testCoverageExcludeByFile: "*/*Designer.cs;*/*.g.cs;*/*.g.i.cs");
 

diff --git a/src/Cake.Issues.PullRequests.AppVeyor.Tests/Cake.Issues.PullRequests.AppVeyor.Tests.csproj b/src/Cake.Issues.PullRequests.AppVeyor.Tests/Cake.Issues.PullRequests.AppVeyor.Tests.csproj
@@ -14,14 +14,14 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cake.Issues.Testing" Version="0.9.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.6.1" />
-    <PackageReference Include="Cake.Core" Version="0.33.0" />
-    <PackageReference Include="Cake.Testing" Version="0.33.0" />
-    <PackageReference Include="Shouldly" Version="3.0.2" />
+    <PackageReference Include="Cake.Issues.Testing" Version="1.0.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
+    <PackageReference Include="Cake.Core" Version="1.0.0" />
+    <PackageReference Include="Cake.Testing" Version="1.0.0" />
+    <PackageReference Include="Shouldly" Version="4.0.3" />
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118" />
     <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.2" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
   </ItemGroup>
 
   <ItemGroup>

diff --git a/src/Cake.Issues.PullRequests.AppVeyor/Cake.Issues.PullRequests.AppVeyor.csproj b/src/Cake.Issues.PullRequests.AppVeyor/Cake.Issues.PullRequests.AppVeyor.csproj
@@ -10,6 +10,7 @@
   <PropertyGroup>
     <DebugType>full</DebugType>
     <DebugSymbols>true</DebugSymbols>
+    <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <CodeAnalysisRuleSet>..\Cake.Issues.PullRequests.AppVeyor.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
 
@@ -22,11 +23,14 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Cake.Common" Version="0.33.0" PrivateAssets="All" />
-    <PackageReference Include="Cake.Core" Version="0.33.0" PrivateAssets="All" />
-    <PackageReference Include="Cake.Issues" Version="0.9.0" />
-    <PackageReference Include="Cake.Issues.PullRequests" Version="0.9.0" />
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0" />
+    <PackageReference Include="Cake.Common" Version="1.0.0" PrivateAssets="All" />
+    <PackageReference Include="Cake.Core" Version="1.0.0" PrivateAssets="All" />
+    <PackageReference Include="Cake.Issues" Version="1.0.0" />
+    <PackageReference Include="Cake.Issues.PullRequests" Version="1.0.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="5.0.3">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118" />
   </ItemGroup>
 

diff --git a/src/Cake.Issues.PullRequests.AppVeyor/IIssueExtensions.cs b/src/Cake.Issues.PullRequests.AppVeyor/IIssueExtensions.cs
@@ -5,7 +5,7 @@
     /// <summary>
     /// Extensions for <see cref="IIssue"/>.
     /// </summary>
-    public static class IIssueExtensions
+    internal static class IIssueExtensions
     {
         /// <summary>
         /// Returns the corresponding category of an AppVeyor message for an issue priority.