This repository has been archived by the owner on Feb 16, 2021. It is now read-only.
Add possibility to limit posted issues for a specific provider #158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed:
This pullrequest introduces a new property
ProviderType
to theIPullRequestDiscussionThread
interface.The
ProviderType
is being used to restrict each providers issues by either a maximum limit across all runs or a limit for each individual run.The report settings interface
IReportIssuesToPullRequestSettings
has retrieved a new propertyProviderIssueLimits
, which can be used to set the limits for each individual provider type. It is implemented with a dictionary which has the key = the providertype to which the limits should be applied. The dictionary value is a new interfaceIProviderIssueLimits
, which holds the propertiesMaxIssuesToPost
andMaxIssuesToPostAcrossRuns
to configure the limits.I have made the already existing
MaxIssuesToPostForEachIssueProvider
obselete, because it basically did the same but you were not able to configure different issues for each provider. The functionality is still working like it was implemented and could be removed in a future release.closes #142 and #141
What's next:
We need to fill
IPullRequestDiscussionThread.ProviderType
@ Cake.Issues.PullRequests.AzureDevOps (see this issue: cake-contrib/Cake.Issues.PullRequests.AzureDevOps#182)