Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .NET Core #4

Closed
pascalberger opened this issue Sep 12, 2017 · 8 comments
Closed

Migrate to .NET Core #4

pascalberger opened this issue Sep 12, 2017 · 8 comments
Labels
Milestone

Comments

@pascalberger
Copy link
Member

pascalberger commented Sep 12, 2017

Addin should support .NET Core and Cake CoreCLR runner

@t-johnson
Copy link
Contributor

I will take this on. standard 1.6 or standard 2.0?

@pascalberger
Copy link
Member Author

pascalberger commented Oct 13, 2017

@t-johnson That would be great!

Stuff which needs to be done:

@RLittlesII @gep13 Since you have already migrated some other plugins, have I forgotten something?

@gep13
Copy link
Member

gep13 commented Oct 13, 2017

If I remember correctly, you need to bump 4.5 to 4.6, which will need a change in the nuspec file as well.

@gep13
Copy link
Member

gep13 commented Oct 13, 2017

On phone just now, but if you find one of @RLittlesII PRs for one of the other addins, that you be a good place to start.

@pascalberger
Copy link
Member Author

@gep13 Thanks. Sure, building against latest Cake requires bumping to .NET 4.6. Also linked to some PRs migrating other addins to .NET Core as guidelines.

@RLittlesII
Copy link

@pascalberger seems to be the correct steps. I think the tricky part is the new csproject format and any odd dependencies. If you want me to look at PR’s let me know.
I might even recommend bumping to net46 in a separate commit as that has caused me some headache.

@t-johnson
Copy link
Contributor

thanks, this is pretty clear on whats expected.

@pascalberger
Copy link
Member Author

Cake 0.22.0 should actually be high enough to support .NET Core. There's therefore no need to build against a newer Cake version. .NET Framework 4.6 is also already targetted. I updated the list above.

@pascalberger pascalberger added this to the 0.2.0 milestone Oct 15, 2017
pascalberger added a commit that referenced this issue Oct 15, 2017
(GH-4) Support multi-targeting, .net standard 1.6 and .net framework 4.6
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 24, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 24, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Dec 25, 2023
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Apr 6, 2024
pascalberger added a commit to pascalberger/Cake.Issues that referenced this issue Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants