Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(typo) Minor correction #4

Merged
merged 1 commit into from
Mar 15, 2017
Merged

(typo) Minor correction #4

merged 1 commit into from
Mar 15, 2017

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Mar 15, 2017

No description provided.

@larzw larzw merged commit ef091ab into cake-contrib:master Mar 15, 2017
@gep13 gep13 deleted the gep13-patch-1 branch March 15, 2017 22:23
@larzw
Copy link
Member

larzw commented Mar 15, 2017

Thanks @gep13!

FYI I've got a Codov cake addin in the works. Just need to finish the exe uploader for their api.

@gep13
Copy link
Member Author

gep13 commented Mar 15, 2017

@larzw noice! That has been on my list of things to look at. Currently using Coveralls.io. Let me know when you have something ready, would like to take a look at it.

@AdmiringWorm
Copy link
Member

@larzw just curious, how is it going with the cake codecov addin?
I was just about to start on my own, when @gep13 told me you were already working on one.

@gep13
Copy link
Member Author

gep13 commented Mar 21, 2017

@larzw @AdmiringWorm if this is something that you would both want to work on, would it make sense to host the repository under the cake-contrib organisation, where I could add you both as administrators, with full rights to the repository?

Thank you both for your interest in creating this addin.

@larzw
Copy link
Member

larzw commented Mar 21, 2017

Hi @AdmiringWorm, I'm currently writing the codecov uploader (#tool for cake script). It's almost done. Steve (the author of codecov) is reviewing it now and has plans to put it into production. I've got something very basic worked out for the addin.

@gep13 I think that is a great idea to host the addin under the cake-contrib organization. I can add my preliminary code on there. I can also create and add everyone as an owner for the nuget package. Is everyone ok with that idea?

@gep13
Copy link
Member Author

gep13 commented Mar 21, 2017

@larzw said...
I can also create and add everyone as an owner for the nuget package. Is everyone ok with that idea?

That would be perfect! From the Cake Team side of things, adding the cake-contrib user as a co-owner of the package is all that would be required.

Once moved into the cake-contrib organisation, I can set up the AppVeyor CI builds, etc.

@larzw thanks for your help on this!

@AdmiringWorm
Copy link
Member

I can also create and add everyone as an owner for the nuget package. Is everyone ok with that idea?

I'm okay with that. Although, if you have most planned out already there probably won't be a need for me, but I'll help out wherever I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants