Merge pull request #41 from cake-contrib/feature/GH-38

(GH-38) Add link to rule Url to comment
cake-contrib · Apr 11, 2017 · 2db1077 · 2db1077
2 parents 62aca2a + 366c6d3
commit 2db1077
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/src/Cake.Prca.PullRequests.Tfs.Tests/ContentProviderTests.cs b/src/Cake.Prca.PullRequests.Tfs.Tests/ContentProviderTests.cs
@@ -1,5 +1,6 @@
 namespace Cake.Prca.PullRequests.Tfs.Tests
 {
+    using System;
     using Issues;
     using Shouldly;
     using Xunit;
@@ -15,31 +16,49 @@ public sealed class TheGetContentClass
                 "Some message",
                 1,
                 "foo",
+                null,
                 "foo: Some message")]
             [InlineData(
                 @"foo.cs",
                 123,
                 "Some message",
                 1,
                 "",
+                null,
                 "Some message")]
             [InlineData(
                 @"foo.cs",
                 123,
                 "Some message",
                 1,
                 " ",
+                null,
                 "Some message")]
+            [InlineData(
+                @"foo.cs",
+                123,
+                "Some message",
+                1,
+                "foo",
+                "http://google.com",
+                "[foo](http://google.com/): Some message")]
             public void Should_Return_Correct_Value(
                 string filePath,
                 int? line,
                 string message,
                 int priority,
                 string rule,
+                string ruleUrl,
                 string expectedResult)
             {
                 // Given
-                var issue = new CodeAnalysisIssue(filePath, line, message, priority, rule, null, "Foo");
+                Uri ruleUri = null;
+                if (!string.IsNullOrWhiteSpace(ruleUrl))
+                {
+                    ruleUri = new Uri(ruleUrl);
+                }
+
+                var issue = new CodeAnalysisIssue(filePath, line, message, priority, rule, ruleUri, "Foo");
 
                 // When
                 var result = ContentProvider.GetContent(issue);

diff --git a/src/Cake.Prca.PullRequests.Tfs/ContentProvider.cs b/src/Cake.Prca.PullRequests.Tfs/ContentProvider.cs
@@ -15,11 +15,19 @@ internal static class ContentProvider
         public static string GetContent(ICodeAnalysisIssue issue)
         {
             var result = issue.Message;
-            if (!string.IsNullOrWhiteSpace(issue.Rule))
+            if (string.IsNullOrWhiteSpace(issue.Rule))
             {
-                result = $"{issue.Rule}: {result}";
+                return result;
             }
 
+            var ruleContent = issue.Rule;
+            if (issue.RuleUrl != null)
+            {
+                ruleContent = $"[{issue.Rule}]({issue.RuleUrl})";
+            }
+
+            result = $"{ruleContent}: {result}";
+
             return result;
         }
     }