Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cake.Graph from Cake.Recipe execution #359

Closed
pascalberger opened this issue Apr 24, 2019 · 1 comment
Closed

Remove Cake.Graph from Cake.Recipe execution #359

pascalberger opened this issue Apr 24, 2019 · 1 comment
Assignees
@pascalberger
Labels
Breaking change
Milestone
2.0.0

Comments

@pascalberger
Copy link
Member

Having documentation for build script tasks makes only sense for Recipe like NuGet packages, but not for all other projects using Cake.Recipe. To have this disabled by default and explicitely enabled for Cake.Recipe would make more sense therefore.
@pascalberger pascalberger self-assigned this Apr 24, 2019
@pascalberger pascalberger added this to the vNext milestone Apr 24, 2019
pascalberger added a commit to pascalberger/Cake.Recipe that referenced this issue Apr 24, 2019
@pascalberger
(cake-contribGH-359) Disable task graphs in documentation by default
f09da87
@pascalberger pascalberger mentioned this issue Apr 24, 2019
Closed
@gep13 gep13 modified the milestones: vNext, 2.0.0 Sep 9, 2019
gep13 pushed a commit that referenced this issue Sep 13, 2019
@pascalberger @gep13
(GH-359) Disable task graphs in documentation by default
d9e4bc9
@gep13 gep13 closed this as completed Sep 13, 2019
@gep13 gep13 changed the title Disable task graphs in documentation by default Remove Cake.Graph from Cake.Recipe execution Sep 16, 2019
@gep13
Copy link
Member

gep13 commented Sep 16, 2019

Initially, we were hoping to only disable Cake.Graph from being enabled by default, however, we ran into a number of problems with getting the build to work when a dependency brought in by Cake.Graph was being used. In the end, we had to remove Cake.Graph completely, which was done as part of this commit:

b451ede

We may look at bringing this back in the future, but for now, it has been removed.

@gep13 gep13 mentioned this issue Sep 16, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalberger pascalberger

Labels
Breaking change
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-359) Disable task graphs in documentation by default pascalberger/Cake.Recipe
2 participants
@gep13 @pascalberger