Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't always delete nupkgs at the end of the build #448

Closed
gep13 opened this issue Sep 16, 2019 · 0 comments
Closed

Don't always delete nupkgs at the end of the build #448

gep13 opened this issue Sep 16, 2019 · 0 comments
Labels
Breaking change
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Sep 16, 2019

This was put in as a mechanism to reduce the amount of hard drive space used when doing lots of builds. However, it is known to cause problems for Cake.Bakery when the nupkgs are not left in place. We should conditionally delete the nupkgs. i.e. as @AdmiringWorm said...

Should probably be conditional, don't delete them on local build and/or if a specific argument is used.
@gep13 gep13 added this to the 2.0.0 milestone Sep 16, 2019
@gep13 gep13 mentioned this issue Sep 16, 2019
Closed
12 tasks
gep13 added a commit that referenced this issue Sep 19, 2019
@gep13
(GH-448) Keep nupkgs at end of build
6132173 
When running on CI system, nupkgs will still be deleted to help with
potential storage issues, but by default, locally, the nupkgs will be
kept around, unless expressly told to delete them.
@gep13 gep13 closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@gep13