Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default wyam edit url to use develop property #513

Closed
AdmiringWorm opened this issue Mar 16, 2020 · 0 comments
Closed

Update default wyam edit url to use develop property #513

AdmiringWorm opened this issue Mar 16, 2020 · 0 comments
Labels
Improvement
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

Currently the default value of the wyam edit url is hard-coded to use the develop branch (sure can be overridden, but would require the full url in that case).

I suggest updating the affected line to make use of the 'DevelopBranch' property instead, so it would match other usages when changing the default develop branch.
@gep13 gep13 added this to the 2.0.0 milestone Jul 7, 2020
gep13 added a commit that referenced this issue Jul 8, 2020
@gep13
(GH-513) Don't hardcode develop branch name
1d7a5aa 
Instead, use the parameter that can be passed in my parent project.
@gep13 gep13 closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@gep13 @AdmiringWorm