Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to control whether or not to run Coveralls #535

Closed
gep13 opened this issue Jul 8, 2020 · 1 comment · Fixed by #540
Closed

Should be able to control whether or not to run Coveralls #535

gep13 opened this issue Jul 8, 2020 · 1 comment · Fixed by #540
Assignees
@gep13
Labels
Improvement
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 8, 2020

Similar to what is possible for Codecov, namely a new parameter called ShouldRunCoveralls
@gep13 gep13 self-assigned this Jul 8, 2020
@gep13 gep13 added this to the 2.0.0 milestone Jul 8, 2020
@AdmiringWorm
Copy link
Member

AdmiringWorm commented Jul 8, 2020 •
edited
Loading

A temporary workaround for anyone interested can be seen here:
cake-contrib/Cake.Codecov@469e621

Just rename the environment variable to expect something you know won't exist.

gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 9, 2020
@gep13
(cake-contribGH-535) Provide ability to not use Coveralls
96b77d7 
Previously, it was assumed that you would always publish to Coveralls,
and the only way to prevent it was to hack the environment variable to
be something that couldn't be found.  This new parameter allows
controlling whether Coveralls should be used.  It will default to true,
since that is how things work just now.
@gep13 gep13 mentioned this issue Jul 9, 2020
Merged
AdmiringWorm added a commit that referenced this issue Jul 9, 2020
@AdmiringWorm
Merge pull request #540 from gep13/feature/GH-535
ccdb616 
(GH-535) Provide ability to not use Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-535) Provide ability to not use Coveralls gep13/Cake.Recipe
2 participants
@gep13 @AdmiringWorm