Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When building source code when not using git, build should still succeed #578

Closed
gep13 opened this issue Jul 16, 2020 · 0 comments · Fixed by #579
Closed

When building source code when not using git, build should still succeed #578

gep13 opened this issue Jul 16, 2020 · 0 comments · Fixed by #579
Assignees
@gep13
Labels
Improvement
Milestone
2.0.0

Comments

@gep13
Copy link
Member

gep13 commented Jul 16, 2020

There is an edge case, which was brought up in a Gitter conversation here where the source code for an application using Cake.Recipe was being run from a direct download of the source code, rather than first cloning the repository.

This fails for a couple of reasons...

  • If git isn't available, then the localBuildProvider instance can't function since the git tool isn't available.
  • If it isn't a git repository, then the execution of GitVersion will fail since the history of the repository isn't in place

We should be able to gracefully handle this edge case.
@gep13 gep13 added this to the 2.0.0 milestone Jul 16, 2020
@gep13 gep13 self-assigned this Jul 16, 2020
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 16, 2020
@gep13
(cake-contribGH-578) Support building when not usng git
1c10e36 
i.e. when the repository hasn't been cloned, but rather downloaded as a
zip file.

When in this situation, default to some sensible values.
@gep13 gep13 mentioned this issue Jul 16, 2020
Merged
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 17, 2020
@gep13
(cake-contribGH-578) Support building when not usng git
53c0528 
i.e. when the repository hasn't been cloned, but rather downloaded as a
zip file.

When in this situation, default to some sensible values.
gep13 added a commit to gep13/Cake.Recipe that referenced this issue Jul 17, 2020
@gep13
(cake-contribGH-578) Support building when not usng git
c83788f 
i.e. when the repository hasn't been cloned, but rather downloaded as a
zip file.

When in this situation, default to some sensible values.
AdmiringWorm added a commit that referenced this issue Jul 17, 2020
@AdmiringWorm
Merge pull request #579 from gep13/feature/GH-578
839ade1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-578) Support building when not using git gep13/Cake.Recipe
1 participant
@gep13