Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling or overriding the framework path override #598

Closed
AdmiringWorm opened this issue Jul 31, 2020 · 2 comments · Fixed by #607
Closed

Allow disabling or overriding the framework path override #598

AdmiringWorm opened this issue Jul 31, 2020 · 2 comments · Fixed by #607
Assignees
@AdmiringWorm
Labels
Feature
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

When running a .NET Core build on Unix system we always add a framework path override.
In some cases, this may be undesirable (like if the projects have the .NET Framework assembly references).

I would suggest allowing this ability to be disabled, and optionally be allowed to pass in a different path to use instead (would be required when cake.recipe support .NET Core only builds).
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone Jul 31, 2020
@gep13
Copy link
Member

gep13 commented Jul 31, 2020

@AdmiringWorm this sounds like a good idea to me. Is this something that you wanted to take a stab at?

@AdmiringWorm
Copy link
Member Author

Were you wanting to take a stab at this?

Yeah, most likely, either during the weekend or sometime next week.
I didn't want to assign myself until I start working on it, as it should be quite simple to implement, and I want to allow other people the opportunity to add the feature if they wish to help out.

@AdmiringWorm AdmiringWorm self-assigned this Aug 4, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Aug 4, 2020
@AdmiringWorm
(cake-contribGH-598) Add parameter for disabling the use of TargetFra…
861089d 
…meworkOverridePath

In some cases, there is no need to use the TargetFrameworkOverridePath
when building .NET Full Framework using .NET Core.
This is especially true if the user already references the needed
reference assemblies provided by Microsoft (which will also
be the default in .NET Core 5.x).
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Aug 4, 2020
@AdmiringWorm
(cake-contribGH-598) Allow specifying a custom directory to use for T…
11905f1 
…argetFrameworkOverridePath
@AdmiringWorm AdmiringWorm mentioned this issue Aug 4, 2020
Merged
@gep13 gep13 closed this as completed in #607 Aug 4, 2020
gep13 added a commit that referenced this issue Aug 4, 2020
@gep13
Merge pull request #607 from AdmiringWorm/feature/gh-598
1d3303f 
(GH-598) Allow users to disable or override target framework path
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Aug 4, 2020
@AdmiringWorm
(cake-contribGH-598) Fix null exception happening on windows
ab84621 
A null exception happens when running on windows,
under cake .net core and mono not being installed.
This commit fixes that issues to only set
shouldUseFrameworkPath to true when running
on Unix
gep13 added a commit that referenced this issue Aug 4, 2020
@gep13
Merge pull request #611 from AdmiringWorm/bugfix/null-exception
d59da23 
(GH-598) Fix null exception happening on windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Feature
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-598) Allow users to disable or override target framework path AdmiringWorm/Cake.Recipe
2 participants
@gep13 @AdmiringWorm