Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publishing steps other than nuget are not attempted when pushing tags directly #708

Closed
AdmiringWorm opened this issue Oct 7, 2020 · 2 comments
Closed

Publishing steps other than nuget are not attempted when pushing tags directly #708

AdmiringWorm opened this issue Oct 7, 2020 · 2 comments
Assignees
@AdmiringWorm
Labels
Bug
Milestone
2.0.1

Comments

@AdmiringWorm
Copy link
Member

In a workflow where tags are pushed directly instead of using Publish on a GitHub release, the tasks for Publishing release notes, sending twitter/slack/gitter messages are never attempted.

This seems to be because we have a check-in place to see if the current run is running of a master/develop/hotfix/release branch.

When pushing the tags directly, these are not associated with any branch unless additional work is done to check if the tag is part of a branch.
@AdmiringWorm
Copy link
Member Author

A possible solution that @gep13 found on stackoverflow: https://stackoverflow.com/questions/15806448/git-how-to-find-out-on-which-branch-a-tag-is

@AdmiringWorm AdmiringWorm added this to the 2.0.1 milestone Oct 8, 2020
@AdmiringWorm AdmiringWorm self-assigned this Oct 8, 2020
AdmiringWorm added a commit to AdmiringWorm/Cake.Recipe that referenced this issue Oct 8, 2020
@AdmiringWorm
(cake-contribGH-708) Add ability to detect branches when running on d…
4aa527a 
…etached tags

This commit adds the ability to detect wether we
are running on one of the supported branches even
in the cases where the current commit is a tag,
and it is not directly attached to a specific branch.
@AdmiringWorm AdmiringWorm mentioned this issue Oct 8, 2020
Merged
gep13 added a commit that referenced this issue Oct 8, 2020
@gep13
Merge pull request #713 from AdmiringWorm/gh-708
29aca9b 
(GH-708) Add ability to detect branches when running on detached tags
@gep13 gep13 closed this as completed Oct 8, 2020
gep13 added a commit that referenced this issue Oct 9, 2020
@gep13
Merge branch 'hotfix/2.0.1' into master
1c6f09c 
* hotfix/2.0.1:
  (build) Updating GRM config
  (GH-705) Update notification messages
  (GH-701) Update wording in nuspec file
  (GH-708) Add ability to detect branches when running on detached tags
  (GH-706) Only add ApiKey when on Azure Artifacts
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit that referenced this issue Oct 9, 2020
@gep13
Merge branch 'hotfix/2.0.1' into develop
8608f40 
* hotfix/2.0.1:
  (build) Updating GRM config
  (GH-705) Update notification messages
  (GH-701) Update wording in nuspec file
  (GH-708) Add ability to detect branches when running on detached tags
  (GH-706) Only add ApiKey when on Azure Artifacts
cake-contrib-bot pushed a commit that referenced this issue Oct 9, 2020
@gep13
Continuous Integration Publish: 8608f40
31579bb 
Merge branch 'hotfix/2.0.1' into develop

* hotfix/2.0.1:
  (build) Updating GRM config
  (GH-705) Update notification messages
  (GH-701) Update wording in nuspec file
  (GH-708) Add ability to detect branches when running on detached tags
  (GH-706) Only add ApiKey when on Azure Artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Bug
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
3 participants
@gep13 @AdmiringWorm @cake-contrib-bot