Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we suggest pinning of virtual environments in CI builds #796

Closed
nils-a opened this issue Feb 24, 2021 · 4 comments · Fixed by #808
Closed

Should we suggest pinning of virtual environments in CI builds #796

nils-a opened this issue Feb 24, 2021 · 4 comments · Fixed by #808
Assignees
Milestone

Comments

@nils-a
Copy link
Contributor

nils-a commented Feb 24, 2021

In light of recent "pin you're Cake version" discussions after the 1.0.0 release:

Should we suggest to pin to a specific virtual environment?

I.e. currently

/cc @gep13 , @AdmiringWorm

@AdmiringWorm
Copy link
Member

TBH, I am not completely sure if we would want to have the example use a specific virtual environment.
What I think could be done though, is to have a notice on the documentation that there are more specific environments that can be used and link to the documentation that lists those environments.

GitHub Actions list those environments here: https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners
and here: https://github.com/actions/virtual-environments/blob/main/README.md

No idea about Azure though.

@nils-a
Copy link
Contributor Author

nils-a commented Mar 1, 2021

Azure docs are here: https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#software

I'll see if I can add a reference to the specific docs, along with a notice.

@nils-a nils-a self-assigned this Mar 1, 2021
@AdmiringWorm
Copy link
Member

I am going back on my previous comment, and I have changed my mind in regards to suggesting that we pin to a virtual image instead.

For GitHub action that would be the image ubuntu-18.04, and probably something similar on azure.
Mostly changed my mind due to the Draft release notes issue that was mentioned on Gary's stream today.

I still think it would be worthwhile to mention other images available, or linking to the official documentation of the available images.

nils-a added a commit to nils-a/Cake.Recipe that referenced this issue Mar 11, 2021
for GitHub Actions and Azure Pipelines.
Also added links to the respective documentations.
gep13 pushed a commit to nils-a/Cake.Recipe that referenced this issue Mar 11, 2021
for GitHub Actions and Azure Pipelines.
Also added links to the respective documentations.
gep13 added a commit that referenced this issue Mar 11, 2021
@gep13 gep13 added this to the 3.0.0 milestone Mar 11, 2021
cake-contrib-bot pushed a commit that referenced this issue Mar 11, 2021
Merge pull request #808 from nils-a/feature/GH-796

(#796) pinned virtual environments
gep13 added a commit that referenced this issue Mar 15, 2021
* upstream/develop:
  (#796) pinned virtual environments
  (#809) removed the suppressing of PR builds
cake-contrib-bot pushed a commit that referenced this issue Mar 15, 2021
Merge remote-tracking branch 'upstream/develop' into develop

* upstream/develop:
  (#796) pinned virtual environments
  (#809) removed the suppressing of PR builds
@cake-contrib-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants