Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gitter #997

Merged
merged 2 commits into from May 2, 2024
Merged

Remove Gitter #997

merged 2 commits into from May 2, 2024

Conversation

Jericho
Copy link
Member

@Jericho Jericho commented Dec 4, 2023

This is a breaking change.

Resolves #995

Copy link
Member

@augustoproiete augustoproiete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for major version release

Jericho and others added 2 commits May 2, 2024 09:57
Gitter was acquired by Element back in 2020:

https://matrix.org/blog/2020/09/30/welcoming-gitter-to-matrix/?ref=blog.gitter.im

And as a result, the Cake.Gitter addin no longer works.  Until there is
an alternative, we need to remove all usage of Gitter from Cake.Recipe.
Since the usage of Gitter is being removed, we should remove mention of
it in the documentation.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 513af36 into cake-contrib:develop May 2, 2024
4 checks passed
@gep13
Copy link
Member

gep13 commented May 2, 2024

@Jericho thank you very much for getting this done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such host is known during teardown
3 participants