Question: How to add "start" parameters?

[o7g8]

Hello,

For integration with GitEnterprise and TeamCity I need to specify following SonarQube parameters:

/d:sonar.analysis.mode=
/d:sonar.useWsCache=
/d:sonar.issuesReport.html.enable=
/d:sonar.issuesReport.console.enable=
/d:sonar.language=
/d:sonar.github.pullRequest=
/d:sonar.github.repository=
/d:sonar.github.login=
/d:sonar.github.oauth=
/d:sonar.github.endpoint=
/d:sonar.github.deleteOldComments=

See also https://docs.sonarqube.org/display/PLUG/GitHub+Plugin

Is it correct that currently one need to add new properties into SonarBeginSettings.cs, which will reflect the additional Sonar parameters?

I wonder if it would make sense to allow Cake users to specify arbitrary Sonar parameters using a weakly typed interface (e.g. via a Dictionary<string, string> on SonarBeginSettings )? Would you accept such change?

Oleg

[tomstaijen]

You can specify custom attributes. SonarBeginSettings inherits from ToolSettings which has a property ArgumentCustomization for that purpose.

…

On Fri, Apr 13, 2018, 5:06 AM Oleg Grytsynevych, ***@***.***> wrote: Hello, For integration with GitEnterprise and TeamCity I need to specify following SonarQube parameters: /d:sonar.analysis.mode= /d:sonar.useWsCache= /d:sonar.issuesReport.html.enable= /d:sonar.issuesReport.console.enable= /d:sonar.language= /d:sonar.github.pullRequest= /d:sonar.github.repository= /d:sonar.github.login= /d:sonar.github.oauth= /d:sonar.github.endpoint= /d:sonar.github.deleteOldComments= See also https://docs.sonarqube.org/display/PLUG/GitHub+Plugin Is it correct that currently one need to add new properties into SonarBeginSettings.cs, which will reflect the additional Sonar parameters? Is it correct? I wonder if it would make sense to allow Cake users to specify arbitrary Sonar parameters using a weakly typed interface (e.g. via a Dictionary<string, string> on SonarBeginSettings? Would you accept such change? Oleg — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#59>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6OHoW8BLHMlZ8M2_ZwpNV38omKuOPXks5toJTQgaJpZM4TTVmo> .

[Tanzy]

Adding a Dictionary<string, string> makes sense to me, makes it easier when making running the task from CakeBuild

[o7g8]

I have posted a PR with "explicit" implementation of the parameters.
I also think the Dictionary<string,string> would simplify life for many people, who use "less popular" SonarQube parameters and plugins. It can be implemented in the next PR.

[tomstaijen]

ArgumentCustomization in ToolSettings does the same thing. Why duplicate that.

https://cakebuild.net/api/Cake.Core.Tooling/ToolSettings/50AAB3A8