Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Repository/Project Update #50

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Aug 22, 2019

@kolesnick as part of the generated audit that is completed here:

https://github.com/cake-contrib/Home/blob/master/Audit.xlsx

A couple of best practices additions to the NuGet Metadata are currently missing from the package. The PR addresses that, as well as making a couple of other changes to bring some of the repository files up to date.

Please let me know if you have any questions.

This provides some immediate information that a repository is using
Cake.Recipe, and it is a convention now followed by a number of other
repositories.
So that builds work on other operating systems.
@gep13 gep13 requested a review from kolesnick August 22, 2019 20:39
@gep13
Copy link
Member Author

gep13 commented Sep 6, 2019

@kolesnick just wanted to touch base to see if you had any questions about any of the changes I suggested here?

@kolesnick kolesnick merged commit 6431bbd into cake-contrib:develop Oct 23, 2019
@kolesnick
Copy link
Member

kolesnick commented Oct 23, 2019

@gep13
LGTM, thank you!
Sorry for delay.

Copy link
Member

@kolesnick kolesnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gep13
Copy link
Member Author

gep13 commented Oct 23, 2019

@kolesnick no need to apologise. Thanks for merging!

@gep13 gep13 deleted the general-update branch October 23, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants