Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon is not visible in current nupgk on nuget #10

Closed
nils-a opened this issue Aug 7, 2020 · 2 comments · Fixed by #12
Closed

Icon is not visible in current nupgk on nuget #10

nils-a opened this issue Aug 7, 2020 · 2 comments · Fixed by #12
Assignees
@nils-a
Labels
bug Something isn't working
Milestone
1.0.4

Comments

@nils-a
Copy link
Contributor

nils-a commented Aug 7, 2020

image
@nils-a nils-a added the bug Something isn't working label Aug 7, 2020
@nils-a nils-a added this to the 1.0.4 milestone Aug 7, 2020
@nils-a nils-a self-assigned this Aug 7, 2020
@nils-a
Copy link
Contributor Author

nils-a commented Aug 7, 2020 •
edited

This does not happen on local builds:
image

It seems the build on appyeyor is not producing the <icon> tag in the nuspec:
image

@nils-a
Copy link
Contributor Author

nils-a commented Aug 7, 2020

appveyor is using vs2017 currently

cake.asciidoctorj/.appveyor.yml

Line 2 in b37de0a

- Visual Studio 2017

I can not find any official docs but https://aka.ms/deprecateIconUrl suggests msbuild <PackageIcon> is supported starting VS 2019.

Also https://aka.ms/deprecateIconUrl suggests adding <PackageIconUrl> for compatability-reasons.

nils-a added a commit that referenced this issue Aug 7, 2020
@nils-a
(GH-10) switched appveyor image VS 2019 and addded PackageIconUrl for…
1e8cdab 
… compatibility.
@nils-a nils-a linked a pull request Aug 7, 2020 that will close this issue
(GH-10) switched appveyor image VS 2019 #12
Merged
nils-a added a commit that referenced this issue Aug 8, 2020
@nils-a
(GH-10) switched appveyor image VS 2019 (#12)
af53332 
* (GH-10) switched appveyor image VS 2019 and addded PackageIconUrl for compatibility.
This was referenced Aug 8, 2020
Merged
Closed
@nils-a nils-a closed this as completed Aug 8, 2020
nils-a added a commit that referenced this issue Aug 8, 2020
@nils-a
Merge pull request #13 from cake-contrib/release/1.0.4
c57b9ab 
fix GH-10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nils-a nils-a

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

(GH-10) switched appveyor image VS 2019 cake-contrib/cake.asciidoctorj
1 participant
@nils-a