Cw 604 integrate bitcoin ledger #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # android/app/src/main/AndroidManifestBase.xml # cw_bitcoin/lib/bitcoin_wallet_service.dart # cw_core/lib/wallet_service.dart # cw_monero/lib/monero_wallet_service.dart # res/values/strings_ar.arb # res/values/strings_bg.arb # res/values/strings_cs.arb # res/values/strings_de.arb # res/values/strings_en.arb # res/values/strings_es.arb # res/values/strings_fr.arb # res/values/strings_ha.arb # res/values/strings_hi.arb # res/values/strings_hr.arb # res/values/strings_id.arb # res/values/strings_it.arb # res/values/strings_ja.arb # res/values/strings_ko.arb # res/values/strings_my.arb # res/values/strings_nl.arb # res/values/strings_pl.arb # res/values/strings_pt.arb # res/values/strings_ru.arb # res/values/strings_th.arb # res/values/strings_tl.arb # res/values/strings_tr.arb # res/values/strings_uk.arb # res/values/strings_ur.arb # res/values/strings_yo.arb # res/values/strings_zh.arb
# Conflicts: # cw_bitcoin/lib/bitcoin_wallet_service.dart # cw_bitcoin_cash/lib/src/bitcoin_cash_wallet_service.dart # cw_core/lib/hive_type_ids.dart # cw_core/lib/wallet_base.dart # cw_core/lib/wallet_info.dart # cw_core/lib/wallet_service.dart # cw_ethereum/lib/ethereum_wallet_service.dart # cw_monero/lib/monero_wallet_service.dart # cw_nano/lib/nano_wallet_service.dart # cw_polygon/lib/polygon_wallet_service.dart # lib/di.dart # lib/ethereum/cw_ethereum.dart # lib/src/screens/send/send_page.dart # pubspec_base.yaml # res/values/strings_de.arb # tool/configure.dart
# Conflicts: # lib/src/screens/send/send_page.dart
|
please update this with the latest |
…nto CW-604-integrate-bitcoin-ledger # Conflicts: # cw_bitcoin/lib/bitcoin_wallet.dart # cw_bitcoin/lib/bitcoin_wallet_service.dart # cw_core/lib/hardware/device_connection_type.dart # cw_core/lib/hardware/hardware_account_data.dart # cw_evm/lib/evm_chain_hardware_wallet_service.dart # lib/ethereum/cw_ethereum.dart # lib/polygon/cw_polygon.dart # lib/routes.dart # lib/src/screens/connect_device/connect_device_page.dart # lib/src/screens/connect_device/debug_device_page.dart # lib/src/screens/connect_device/select_hardware_wallet_account_page.dart # lib/view_model/hardware_wallet/ledger_view_model.dart # lib/view_model/wallet_hardware_restore_view_model.dart
OmarHatem28
requested changes
May 3, 2024
| import 'package:ledger_bitcoin/ledger_bitcoin.dart'; | ||
| import 'package:ledger_flutter/ledger_flutter.dart'; | ||
|
|
||
| class BitcoinHardwareWalletService { |
There was a problem hiding this comment.
Enhancement (make it in a separate enhancement PR later, or when we get to add Monero hardware wallet)
let's make a Parent class in cw_core that has the functions that must be overridden by each child class
OmarHatem28
requested changes
May 3, 2024
OmarHatem28
requested changes
May 3, 2024
…CW-604-integrate-bitcoin-ledger
… into CW-604-integrate-bitcoin-ledger
…CW-604-integrate-bitcoin-ledger � Conflicts: � cw_core/lib/hive_type_ids.dart � lib/di.dart
…CW-604-integrate-bitcoin-ledger
fix tron address validation
OmarHatem28
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Bitcoin Support for Ledger
Is based upon #1310
Pull Request - Checklist