Use 'Acl.' as plugin prefix and pluralized class name in ACL behavior #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasMany associations should always use the pluralized association name: https://book.cakephp.org/4/en/orm/associations.html#hasmany-associations
This resolves an issue where the Acl Plugin itself used autogenerated Cake\ORM\Table instead of Acl\Model\Table\
rcbrites
approved these changes
May 19, 2022
markstory
reviewed
Aug 8, 2022
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "cakephp/acl", | |||
| "name": "itnovum/acl", | |||
There was a problem hiding this comment.
This will need to be reverted in order to be merged.
| @@ -113,7 +114,12 @@ public function node($ref = null, $type = null) | |||
| throw new Exception\Exception(__d('cake_dev', 'ref parameter must be a string or an Entity')); | |||
| } | |||
|
|
|||
| return $this->_table->{$type}->node($ref); | |||
| if(property_exists($this->_table, $type)){ | |||
There was a problem hiding this comment.
Suggested change
| if(property_exists($this->_table, $type)){ | |
| if (property_exists($this->_table, $type)){ |
You'll need to apply the code formatting standards. You can do that with vendor/phpcbf src tests
There was a problem hiding this comment.
Hi @markstory sorry for my late response to this.
I have created a new branch to merge the upstream changes. I also executed phpcbf but this had made so many code changes, that I would recommend to do this in a second step.
A TOTAL OF 526 ERRORS WERE FIXED IN 53 FILES
I guess otherwise the diff is getting to large. What do you think?
There was a problem hiding this comment.
Sure, we can update phpcs separately.
|
Closing as #180 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AclBehavior used the singular table name to add the
hasManyassociation which leats to usage of the wrong table.I also replaced
App::className()withAcl.because the Acl Plugin was using generic auto generatedCake\ORM\Tableinstead ofAcl\Model\Table\I checked some other CakePHP plugins and none of it was using
App::className()