Fix _checkMethods() for abstract controllers #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: AclExtras::_checkMethods() Exception if it faces abstract controller cakephp#40
| $reflectionClass = new \ReflectionClass( $namespace ); | ||
| $actions = null; | ||
| if ($reflectionClass->IsInstantiable()) { | ||
| $actions = get_class_methods(new $namespace); |
There was a problem hiding this comment.
This is probably a bad idea given that the class may have required constructor parameters. It might be better to use the reflection instance to get the methods.
There was a problem hiding this comment.
It would fail only if constructor throws something at you, this is probably what you meant by required parameters. I think that missing parameters will only generate warnings.
You are right that ReflectionClass is way to go, and we already have it in this soup.
I'll fix it.
Using reflection we don't need to worry about code inside controller constructors. \ReflectionMethod::IS_PUBLIC filter added as only public methods will be accessible as controller actions.
|
Looks like there are some conflicts that need to be resolved before this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AclExtras::_checkMethods() Exception if it faces abstract controller #40