Move cake executables into bin directory #123
Conversation
|
Installer.php is fine where it is. |
|
Nice! thanks for taking care of this |
Move cake executables into bin directory
|
Will take care of docs in a few. |
|
Closed now that docs PR is open: cakephp/docs#1670 |
| @@ -27,5 +27,8 @@ | |||
| }, | |||
| "scripts": { | |||
| "post-install-cmd": "App\\Console\\Installer::postInstall" | |||
| }, | |||
| "config" : { | |||
| "bin-dir" : "bin" | |||
There was a problem hiding this comment.
Does this also move the other scripts that composer normally installs like phpunit?
There was a problem hiding this comment.
From what I saw, just boris. But I'm not at my computer right now.
Sent from my iPhone
On Aug 29, 2014, at 20:48, Mark Story notifications@github.com wrote:
In composer.json:
@@ -27,5 +27,8 @@
},
"scripts": {
"post-install-cmd": "App\Console\Installer::postInstall"
- },
- "config" : {
"bin-dir" : "bin"�
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
I bet it will move phpunit as well. That's not necessarily a problem, but something we'll have to update in the documentation.
There was a problem hiding this comment.
I would like to see the bin-dir config change in composer.json reverted
bin/cake is an application binary, i would not want to end up all vendors binaries in there as well
There was a problem hiding this comment.
bin/cake is an application binary, i would not want to end up all vendors binaries in there as well
I don't like that either.
There was a problem hiding this comment.
One problem with moving the bin stub is that it won't actually do anything in the cakephp/cakephp repo. Is it a good idea to have a non-functioning script in the repo?
There was a problem hiding this comment.
True. I guess that does not make sense either. Another suggestion would be
for the postinstall command to create the symlink?
Op 15 okt. 2014 17:06 schreef "Mark Story" notifications@github.com:
In composer.json:
@@ -27,5 +27,8 @@
},
"scripts": {
"post-install-cmd": "App\Console\Installer::postInstall"
- },
- "config" : {
"bin-dir" : "bin"One problem with moving the bin stub is that it won't actually do anything
in the cakephp/cakephp repo. Is it a good idea to have a non-functioning
script in the repo?—
Reply to this email directly or view it on GitHub
https://github.com/cakephp/app/pull/123/files#r18899259.
There was a problem hiding this comment.
Do we have a consensus on removing bin-dir config from composer.json?
2014-10-15 17:58 GMT+02:00 Ceeram c33ram@gmail.com:
True. I guess that does not make sense either. Another suggestion would be
for the postinstall command to create the symlink?
Op 15 okt. 2014 17:06 schreef "Mark Story" notifications@github.com:In composer.json:
@@ -27,5 +27,8 @@
},
"scripts": {
"post-install-cmd": "App\Console\Installer::postInstall"
- },
- "config" : {
"bin-dir" : "bin"One problem with moving the bin stub is that it won't actually do
anything in the cakephp/cakephp repo. Is it a good idea to have a
non-functioning script in the repo?—
Reply to this email directly or view it on GitHub
https://github.com/cakephp/app/pull/123/files#r18899259.
There was a problem hiding this comment.
Not on my part, I like all binaries in the bin folder
Refs cakephp/cakephp#4347
Note: wasn't sure if we should just leave
Installer.phpinsrc/Console... heh, but I did. Open to suggestions on a better location or directory name for it.