Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plugin::routes() #610

Merged
merged 1 commit into from
May 26, 2018
Merged

Remove Plugin::routes() #610

merged 1 commit into from
May 26, 2018

Conversation

markstory
Copy link
Member

When using the new plugin system this method is no longer necessary as
the plugin classes include routes during application startup.

Refs #593

When using the new plugin system this method is no longer necessary as
the plugin classes include routes during application startup.

Refs #593
@markstory markstory added this to the 3.6.x milestone May 25, 2018
Copy link
Member

@josegonzalez josegonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead comment this out? Not all plugins use the new plugin classes.

@markstory
Copy link
Member Author

The plugins don't need to use the new plugin classes. As long as the app uses Application plugin classes will be created dynamically if they are not provided by the plugins.

@markstory markstory merged commit 0e0bcfe into master May 26, 2018
@markstory markstory deleted the issue-593 branch May 26, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants