Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a cookie authenticator #26

Closed
burzum opened this issue Dec 7, 2016 · 5 comments
Closed

Adding a cookie authenticator #26

burzum opened this issue Dec 7, 2016 · 5 comments

Comments

@burzum
Copy link
Contributor

burzum commented Dec 7, 2016

I know this exists https://github.com/Xety/Cake3-CookieAuth/blob/master/src/Auth/CookieAuthenticate.php but the code is really trivial to do and maintain with our identifiers. :) So what about shipping the plugin with a cookie authenticator out of the box?

Edit: We'll implement it, just have to wait for the Cookie changes that we need to get done before in the request and response objects.

@dereuromark
Copy link
Member

dereuromark commented Dec 7, 2016

Sounds like a good idea to me!
It is a very frequently asked for feature. And some good and secure practices around it don't hurt either.

@ADmad
Copy link
Member

ADmad commented Dec 7, 2016

Sure, once the API is finalized.

@burzum
Copy link
Contributor Author

burzum commented Dec 11, 2016

We'll also need to work on the cookie handling because right now we're stuck on the component, which is not available in the middleware stack... I've already discussed the issue with Mark Story. We'll address it and add the cookie authenticator when this has been done.

@burzum burzum removed the RFC label Jan 19, 2017
@burzum burzum changed the title Adding a cookie authenticator? Adding a cookie authenticator Jan 19, 2017
@burzum
Copy link
Contributor Author

burzum commented May 2, 2017

There is a branch open for this feature if somebody wants to help:

https://github.com/cakephp/authentication/tree/cookie-authenticator

@cleptric
Copy link
Member

cleptric commented May 8, 2017

Closing as we have an open PR.

@cleptric cleptric closed this as completed May 8, 2017
robertpustulka added a commit that referenced this issue Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants