3.x: stan update #277
3.x: stan update #277
Conversation
LordSimal
force-pushed
the
3.x-stan-update
branch
from
2692758
to
a2a280a
Compare
src/Command/PolicyCommand.php
Outdated
| @@ -76,7 +76,7 @@ public function templateData(Arguments $arguments): array | |||
| $data = parent::templateData($arguments); | |||
|
|
|||
| $name = $arguments->getArgument('name'); | |||
| if (empty($name)) { | |||
| if ($name === null || $name === '') { | |||
There was a problem hiding this comment.
I don't think this is better but psalm thinks it is 🤷🏻
There was a problem hiding this comment.
if (!$name) was what I had in mind :)
There was a problem hiding this comment.
but psalm is not happy about that one as I described in core chat.
Because then null and '' would be handled in the same if which "could lead to unexpected behavior" according to psalm.
There was a problem hiding this comment.
Thus the silencing on top of it :)
There was a problem hiding this comment.
Otherwise you would have to use
/** @var non-empty-string|null $name */
$name = ...
if ($name === null) if you wanted to make this clean
There was a problem hiding this comment.
Well If I just look at https://www.php.net/manual/en/types.comparisons.php then we didn't really do anything here other than just suppress the warning...
LordSimal
force-pushed
the
3.x-stan-update
branch
from
a2a280a
to
db73f34
Compare
No description provided.