Added license and readme.md, updated namespaces and added composer.json #1
Conversation
| } | ||
| ], | ||
| "extra": { | ||
| "installer-name": "Bake" |
There was a problem hiding this comment.
This is not needed. Plugin installer infers it from the namespace.
|
|
||
| ## License | ||
|
|
||
| Copyright (c) [CURRENT_YEAR] [YOUR_NAME] |
There was a problem hiding this comment.
2014 Cake Software Foundation, Inc.
| "require": { | ||
| "cakephp/bake": "dev-master" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
The recommended way to install composer packages is ´composer require cakephp/bake´.
There was a problem hiding this comment.
Yup, using the command instead of manually editing the file would be preferred.
|
Looks good outside of the existing feedback 👍 |
|
I just fixed that @markstory. I'm also working on getting the tests to work. But I have no idea if I'm doing everything right in the phpunit.xml.dist and the boostrap.php file for the tests. |
…tests. The tests itself are not yet fixed / updated.
| .svn | ||
| errors.err | ||
| tags | ||
| /nbproject/ |
There was a problem hiding this comment.
IMHO all other environment specific files/paths should go in one's global ignore file, not in project's.
There was a problem hiding this comment.
I've taken the file from @markstory DebugKit plugin, so I thought it is OK?
There was a problem hiding this comment.
Okay this way too, just extra cruft but no biggie.
There was a problem hiding this comment.
I'd rather we didn't put editor/user-specific git ignore files in each repo (and if necessary remove them from other projects).
Rather, just add the paths for the given repo - which is probably only /vendor for a plugin
There was a problem hiding this comment.
I don't even know where I got that file. It probably came from the 2.x days.
There was a problem hiding this comment.
So what should I remove from that file? How about creating a clean repo with template files for all the stuff we ever need? Travis, git, readmes, licenses?
There was a problem hiding this comment.
It was @AD7six's fault originally (cakephp/debug_kit@e433aa8#diff-a084b794bc0759e7a6b77810e01874f2), back in 2009. So before the 2.x days, I think that was still 1.2?
There was a problem hiding this comment.
In 2009 it was considered the right thing to do.
Until it was recognised that it means maintaining a long list of ignores in every project instead of just pointing users in the direction of creating a global ignore.
Correct tests to use/rely on files in this repo, rather than test files that are in cakephp/cakephp Closes #1 Merge branch 'pr/1' * pr/1: add test_app files Convert BakeView ot use the string comparison trait Rename the tests/bake_compare folder Add tests to the dev autload only ignore relevant project paths Adding .gitignore Adding phpunit.xml.dist and bootstrap.php to be able to run the unit tests. The tests itself are not yet fixed / updated. More fixes to namespaces Updating the install instructions in the README.md Adding the copyright year and copyright holder to the README.md Removing installer-name from composer.json, it is not needed Cleaning up some more namespace use statements Adding composer.json Adding LICENSE.txt and README.md Updating namespace
ghost
mentioned this pull request
Add scope attribute to table
No description provided.