Only fail subcommands when they exit non-zero. #53
Conversation
Instead of looking in stderr, the exit code of a process should be used to determine whether or not it worked. Refs #51
Only fail subcommands when they exit non-zero.
|
|
||
| if ($error) { | ||
| if ($exit != 0) { |
There was a problem hiding this comment.
Does this need to be a strict check?
There was a problem hiding this comment.
Can be less strict i.e. if ($exit) {
There was a problem hiding this comment.
I am thinking about false positives when returning a string like "foobar", which would then be false (unexpected) with != 0, while true (expected) with strict checks.
There was a problem hiding this comment.
The return value of proc_close is an int.
There was a problem hiding this comment.
Right, so the strict check would be best regarding the guideline "be as as strict as possible".
There was a problem hiding this comment.
well, it's academic really. We know it's a number and to me this is clearer:
if ($exit) {
instead of:
if ($exit !== 0) {
For me that involves mental shuffling whereas "if exit go here" does not.
Instead of looking in stderr, the exit code of a process should be used to determine whether or not it worked.
Refs #51