Update for Cake 5. #836
Update for Cake 5. #836
Conversation
ADmad
force-pushed
the
cake5-updates
branch
5 times, most recently
from
859320d
to
da49353
Compare
|
@othercorey Slevomat CS is barfing on EDIT: Figured it out. It blew up because a docblock had |
ADmad
force-pushed
the
cake5-updates
branch
5 times, most recently
from
d6cbe1a
to
df53683
Compare
phpstan decided to change the return type which broke slevomat. |
src/BakePlugin.php
Outdated
| use DirectoryIterator; | ||
| use ReflectionClass; | ||
| use ReflectionException; | ||
|
|
||
| /** | ||
| * Plugin class for bake | ||
| */ | ||
| class Plugin extends BasePlugin | ||
| class BakePlugin extends BasePlugin | ||
| { | ||
| /** | ||
| * Plugin name. | ||
| * | ||
| * @var string |
There was a problem hiding this comment.
| * @var string | |
| * @var string|null |
if you meant for this to be nullable
There was a problem hiding this comment.
I wish we didn't have to add these redundant docblock types anymore :(.
There was a problem hiding this comment.
We need to do a test with the slevomat setting that detects redundant blocks. I don't know if it forces all @param annotations to be removed even if there's a description you want to keep. Should we just not have comments on parameters annotations anymore?
There was a problem hiding this comment.
I don't think we should drop parameter comments but I doubt it would allow param description without the type.
There was a problem hiding this comment.
Need to test if a comment prevents it from being marked useless.
There was a problem hiding this comment.
I would rather check why the sniffs are missing for it:
https://github.com/spryker/code-sniffer/blob/master/Spryker/Sniffs/Commenting/DocBlockReturnNullSniff.php
or
https://github.com/spryker/code-sniffer/blob/master/Spryker/Sniffs/Commenting/DocBlockReturnNullableTypeSniff.php
could be the right direction here.
As long as they are properly synced, which is easier, all is well.
|
looks good. |
No description provided.