Fix error when trying to bake with non-existent plugins directory. #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused due to `Bake.theme` option defaulting to empty string instead of null and hence a plugin with empty name was being searched causing an exception. Closes #909
|
I don't understand why |
|
The theme could also be empty string |
|
@LordSimal It's a safe guard against someone setting the theme to an empty string. |
|
Just saying: Even with this fix I still get the error from the issue when trying to bake a plugin with a non existent |
|
Forget that... I had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused due to
Bake.themeoption defaulting to empty string instead of null and hence a plugin with empty name was being searched causing an exception.Closes #909