Make backing type a bool, since it defaults anyway on 1 of 2 options. #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, but I think this is a confusing option. Maybe if it was |
|
So just --int ? |
markstory
reviewed
Dec 26, 2023
| )->addOption('int', [ | ||
| 'help' => 'Using backed enums with int instead of string as return type', | ||
| 'boolean' => true, | ||
| 'short' => 'i', |
There was a problem hiding this comment.
I don't know if we need a short option for this as int isn't that long.
There was a problem hiding this comment.
Well, it can still be convinient :)
dereuromark
added a commit
that referenced
this pull request
Dec 27, 2023
* Allow baking enums. * Allow baking enums. * Rephrase options help. * Update templates/bake/Model/enum.twig Co-authored-by: ADmad <ADmad@users.noreply.github.com> * Fix tests * Rename option `backed` to `backing-type` defaulting to `string`. * Clarify backed. * Make backing type a bool, since it defaults anyway on 1 of 2 options. (#971) * Make backing type a bool, since it defaults anyway on 1 of 2 options. * Use --int / -i as flag. --------- Co-authored-by: ADmad <ADmad@users.noreply.github.com> Co-authored-by: ADmad <admad.coder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#968
I would still like to at least propose this for consideration.
Given that there are now only 2 - and string by default, it seems kind of overkill to have a full option for it.
It seems
-icould suffice?