Remove usage of prefix increment operator.

This operator is less frequently used and can be harder to understand than the more common suffix operator. Refs #12019
cakephp · Apr 28, 2018 · 1cca695 · 1cca695
1 parent ad32913
commit 1cca695
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/src/Core/PluginCollection.php b/src/Core/PluginCollection.php
@@ -131,7 +131,7 @@ public function get($name)
      */
     public function next()
     {
-        ++$this->position;
+        $this->position++;
     }
 
     /**

diff --git a/src/Filesystem/Folder.php b/src/Filesystem/Folder.php
@@ -662,7 +662,7 @@ public function dirsize()
         $directory = Folder::slashTerm($this->path);
         $stack = [$directory];
         $count = count($stack);
-        for ($i = 0, $j = $count; $i < $j; ++$i) {
+        for ($i = 0, $j = $count; $i < $j; $i++) {
             if (is_file($stack[$i])) {
                 $size += filesize($stack[$i]);
             } elseif (is_dir($stack[$i])) {

diff --git a/src/Utility/Text.php b/src/Utility/Text.php
@@ -138,7 +138,7 @@ public static function tokenize($data, $separator = ',', $leftBound = '(', $righ
                         }
                     }
                 }
-                $offset = ++$tmpOffset;
+                $offset = $tmpOffset++;
             } else {
                 $results[] = $buffer . mb_substr($data, $offset);
                 $offset = $length + 1;

diff --git a/src/View/Helper/HtmlHelper.php b/src/View/Helper/HtmlHelper.php
@@ -982,10 +982,11 @@ protected function _renderCells($line, $useCount = false)
             }
 
             if ($useCount) {
+                $i += 1;
                 if (isset($cellOptions['class'])) {
-                    $cellOptions['class'] .= ' column-' . ++$i;
+                    $cellOptions['class'] .= ' column-' . $i;
                 } else {
-                    $cellOptions['class'] = 'column-' . ++$i;
+                    $cellOptions['class'] = 'column-' . $i;
                 }
             }