Skip to content

Commit

Permalink
clean up assertions now that we are dropping the fixture early
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastienbarre committed Mar 10, 2017
1 parent a0e023d commit 1ebdc61
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/Cake/Test/Case/Model/CakeSchemaTest.php
Expand Up @@ -702,11 +702,11 @@ public function testSchemaReadWithNonConventionalPrimaryKey() {

$hasTable = isset($read['tables']['non_conventional']);
$this->assertTrue($hasTable, 'non_conventional table should appear');
$versionIdHasKey = $hasTable && isset($read['tables']['non_conventional']['version_id']['key']);
$versionIdHasKey = isset($read['tables']['non_conventional']['version_id']['key']);
$this->assertTrue($versionIdHasKey, 'version_id key should be set');
$versionIdKeyIsPrimary = $versionIdHasKey && $read['tables']['non_conventional']['version_id']['key'] === 'primary';
$versionIdKeyIsPrimary = $read['tables']['non_conventional']['version_id']['key'] === 'primary';
$this->assertTrue($versionIdKeyIsPrimary, 'version_id key should be primary');
$idHasNoKey = $hasTable && !isset($read['tables']['non_conventional']['id']['key']);
$idHasNoKey = !isset($read['tables']['non_conventional']['id']['key']);
$this->assertTrue($idHasNoKey, 'id key should not be set');
}

Expand Down

0 comments on commit 1ebdc61

Please sign in to comment.