Optimizing helper loading loop in View::_render()

cakephp · Feb 6, 2009 · 2317420 · 2317420
1 parent c200fcb
commit 2317420
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/cake/libs/view/view.php b/cake/libs/view/view.php
@@ -645,13 +645,13 @@ function _render($___viewFn, $___dataForView, $loadHelpers = true, $cached = fal
 
 		if ($this->helpers != false && $loadHelpers === true) {
 			$loadedHelpers = $this->_loadHelpers($loadedHelpers, $this->helpers);
+			$helpers = array_keys($loadedHelpers);
+			$helperNames = array_map(array('Inflector', 'variable'), $helpers);
 
-			foreach (array_keys($loadedHelpers) as $helper) {
-				$camelBackedHelper = Inflector::variable($helper);
-				${$camelBackedHelper} =& $loadedHelpers[$helper];
-				$this->loaded[$camelBackedHelper] =& ${$camelBackedHelper};
+			for ($i = count($helpers) - 1; $i >= 0; $i--) {
+				${$helperNames[$i]} =& $loadedHelpers[$helpers[$i]];
+				$this->loaded[$helperNames[$i]] =& ${$helperNames[$i]};
 			}
-
 			$this->_triggerHelpers('beforeRender');
 		}