Fix Validator::equals() never passing.

This method would always trigger validation errors as the conditions were incorrectly defined. Refs #9238
cakephp · Aug 9, 2016 · 26e6bf0 · 26e6bf0
1 parent 3d3e354
commit 26e6bf0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Validation/Validator.php b/src/Validation/Validator.php
@@ -729,7 +729,7 @@ public function equals($field, $value, $message = null, $when = null)
         $extra = array_filter(['on' => $when, 'message' => $message]);
 
         return $this->add($field, 'equals', $extra + [
-            'rule' => ['comparison', '=', $value]
+            'rule' => ['comparison', '==', $value]
         ]);
     }
 

diff --git a/tests/TestCase/Validation/ValidatorTest.php b/tests/TestCase/Validation/ValidatorTest.php
@@ -1190,7 +1190,8 @@ public function testLessThanOrEqual()
     public function testEquals()
     {
         $validator = new Validator();
-        $this->assertProxyMethod($validator, 'equals', 5, ['=', 5], 'comparison');
+        $this->assertProxyMethod($validator, 'equals', 5, ['==', 5], 'comparison');
+        $this->assertEmpty($validator->errors(['username' => 5]));
         $this->assertNotEmpty($validator->errors(['username' => 6]));
     }