Merge pull request #11521 from gotoeveryone/features/client-204

Add to `203` and `204` allowed status code at `Cake\Http\Client\Response::isOk()`
cakephp · Dec 9, 2017 · 3692f76 · 3692f76
2 parents 829778d + 9dbdfd5
commit 3692f76
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/src/Http/Client/Message.php b/src/Http/Client/Message.php
@@ -45,6 +45,20 @@ class Message
      */
     const STATUS_ACCEPTED = 202;
 
+    /**
+     * HTTP 203 code
+     *
+     * @var int
+     */
+    const STATUS_NON_AUTHORITATIVE_INFORMATION = 203;
+
+    /**
+     * HTTP 204 code
+     *
+     * @var int
+     */
+    const STATUS_NO_CONTENT = 204;
+
     /**
      * HTTP 301 code
      *

diff --git a/src/Http/Client/Response.php b/src/Http/Client/Response.php
@@ -236,7 +236,9 @@ public function isOk()
         $codes = [
             static::STATUS_OK,
             static::STATUS_CREATED,
-            static::STATUS_ACCEPTED
+            static::STATUS_ACCEPTED,
+            static::STATUS_NON_AUTHORITATIVE_INFORMATION,
+            static::STATUS_NO_CONTENT
         ];
 
         return in_array($this->code, $codes);

diff --git a/tests/TestCase/Http/Client/ResponseTest.php b/tests/TestCase/Http/Client/ResponseTest.php
@@ -215,6 +215,20 @@ public function testIsOk()
         $response = new Response($headers, 'ok');
         $this->assertTrue($response->isOk());
 
+        $headers = [
+            'HTTP/1.1 203 Non-Authoritative Information',
+            'Content-Type: text/html'
+        ];
+        $response = new Response($headers, 'ok');
+        $this->assertTrue($response->isOk());
+
+        $headers = [
+            'HTTP/1.1 204 No Content',
+            'Content-Type: text/html'
+        ];
+        $response = new Response($headers, 'ok');
+        $this->assertTrue($response->isOk());
+
         $headers = [
             'HTTP/1.1 301 Moved Permanently',
             'Content-Type: text/html'