Permalink
Browse files

Fix failing test, find('first') now returns empty array when no recor…

…d was found
  • Loading branch information...
1 parent a0665fe commit 39dcb80b451dec37e44750482a0d207109dcac11 @ceeram ceeram committed Oct 26, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/Cake/Test/Case/Console/Command/AclShellTest.php
@@ -177,7 +177,7 @@ public function testDelete() {
$Aro = ClassRegistry::init('Aro');
$result = $Aro->findById(3);
- $this->assertFalse($result);
+ $this->assertEmpty($result);
@bar

bar Oct 26, 2012

Contributor

I think it should be $this->assertEquals(array(), $result); to be more strict and test for an empty array.

@ceeram

ceeram via email Oct 26, 2012

Member
@ceeram

ceeram Oct 26, 2012

Member

Changed to assertSame() now, as assertEquals does not check type

@bar

bar Oct 26, 2012

Contributor

We should do the same with the ones in the original commit https://github.com/cakephp/cakephp/commits/

@ceeram

ceeram via email Oct 26, 2012

Member
@bar

bar Oct 26, 2012

Contributor

Perfect! #922

}
/**

0 comments on commit 39dcb80

Please sign in to comment.