Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improved thrown MissingElementException message
Currently, the exception message is just the file location.name ($file). Added some context.
- Loading branch information
5bb25ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this done this way? Watching this I don't get why is there a
$_messageTemplate
var inMissingElementException
.5bb25ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, taking a look to the
Exception
class I see that maybe just specifying[$file]
instead of$file
would be enough, am I right?5bb25ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was a mistake and was reverted.
5bb25ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uoops.. sorry 😅
5bb25ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad :P