Allow creating form tag without "action" attribute.

Closes #6488
cakephp · May 5, 2015 · 911aafa · 911aafa
1 parent d6c54d8
commit 911aafa
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 4 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -367,11 +367,16 @@ public function create($model = null, array $options = [])
         }
         unset($options['templates']);
 
-        $url = $this->_formUrl($context, $options);
-        $action = $this->Url->build($url);
-        unset($options['url'], $options['action'], $options['idPrefix']);
+        if ($options['url'] === false) {
+            $action = null;
+            $this->_lastAction = '';
+        } else {
+            $url = $this->_formUrl($context, $options);
+            $action = $this->Url->build($url);
 
-        $this->_lastAction($url);
+            $this->_lastAction($url);
+        }
+        unset($options['url'], $options['action'], $options['idPrefix']);
 
         $htmlAttributes = [];
         switch (strtolower($options['type'])) {

diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php
@@ -673,6 +673,26 @@ public function testCreateAutoUrl()
         $this->assertHtml($expected, $result);
     }
 
+    /**
+     * test create() with no url (no "action" attribute for <form> tag)
+     *
+     * @return void
+     */
+    public function testCreateNoUrl()
+    {
+        $result = $this->Form->create(false, ['url' => false]);
+        $expected = [
+            'form' => [
+                'method' => 'post',
+                'accept-charset' => strtolower(Configure::read('App.encoding'))
+            ],
+            'div' => ['style' => 'display:none;'],
+            'input' => ['type' => 'hidden', 'name' => '_method', 'value' => 'POST'],
+            '/div'
+        ];
+        $this->assertHtml($expected, $result);
+    }
+
     /**
      * test create() with a custom route
      *