Merge pull request #11764 from cakephp/3.next-better-exception-msg

Improving exception msgs for database types
cakephp · Feb 27, 2018 · bb5e86f · bb5e86f
2 parents d5c11df + c9c0eef
commit bb5e86f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/src/Database/Type/BoolType.php b/src/Database/Type/BoolType.php
@@ -67,7 +67,10 @@ public function toDatabase($value, Driver $driver)
             return (bool)$value;
         }
 
-        throw new InvalidArgumentException('Cannot convert value to bool');
+        throw new InvalidArgumentException(sprintf(
+            'Cannot convert value of type `%s` to bool',
+            getTypeName($value)
+        ));
     }
 
     /**

diff --git a/src/Database/Type/DecimalType.php b/src/Database/Type/DecimalType.php
@@ -80,7 +80,10 @@ public function toDatabase($value, Driver $driver)
             return null;
         }
         if (!is_scalar($value)) {
-            throw new InvalidArgumentException('Cannot convert value to a decimal.');
+            throw new InvalidArgumentException(sprintf(
+                'Cannot convert value of type `%s` to a decimal',
+                getTypeName($value)
+            ));
         }
         if (is_string($value) && is_numeric($value)) {
             return $value;

diff --git a/src/Database/Type/IntegerType.php b/src/Database/Type/IntegerType.php
@@ -64,7 +64,10 @@ public function toDatabase($value, Driver $driver)
         }
 
         if (!is_scalar($value)) {
-            throw new InvalidArgumentException('Cannot convert value to integer');
+            throw new InvalidArgumentException(sprintf(
+                'Cannot convert value of type `%s` to integer',
+                getTypeName($value)
+            ));
         }
 
         return (int)$value;

diff --git a/src/Database/Type/StringType.php b/src/Database/Type/StringType.php
@@ -49,7 +49,10 @@ public function toDatabase($value, Driver $driver)
             return (string)$value;
         }
 
-        throw new InvalidArgumentException('Cannot convert value to string');
+        throw new InvalidArgumentException(sprintf(
+            'Cannot convert value of type `%s` to string',
+            getTypeName($value)
+        ));
     }
 
     /**