Fix missing "for" attribute for datetime input labels.

cakephp · Sep 27, 2019 · c28ad86 · c28ad86
1 parent 0ed805c
commit c28ad86
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/View/Helper/FormHelper.php b/src/View/Helper/FormHelper.php
@@ -242,7 +242,7 @@ class FormHelper extends Helper
      *
      * @var string[]
      */
-    protected $_groupedInputTypes = ['radio', 'multicheckbox', 'date', 'time', 'datetime'];
+    protected $_groupedInputTypes = ['radio', 'multicheckbox'];
 
     /**
      * Construct the widgets and binds the default context providers

diff --git a/tests/TestCase/View/Helper/FormHelperTest.php b/tests/TestCase/View/Helper/FormHelperTest.php
@@ -3410,7 +3410,7 @@ public function testControlDatetime()
         ]);
         $expected = [
             'div' => ['class' => 'input datetime'],
-            '<label',
+            'label' => ['for' => 'prueba'],
             'Prueba',
             '/label',
             'input' => ['name' => 'prueba', 'id' => 'prueba', 'type' => 'datetime-local', 'value' => '2019-09-27T02:52:43'],
@@ -3435,7 +3435,7 @@ public function testControlDatetimeIdPrefix()
         ]);
         $expected = [
             'div' => ['class' => 'input datetime'],
-            '<label',
+            'label' => ['for' => 'prefix-prueba'],
             'Prueba',
             '/label',
             'input' => ['name' => 'prueba', 'id' => 'prefix-prueba', 'type' => 'datetime-local', 'value' => ''],