Merge pull request #13792 from cakephp/4.x-class-magic-constant

Use ::class magic constant instead of string.
cakephp · Oct 22, 2019 · c42e94b · c42e94b
2 parents 29fe42b + 6af2d17
commit c42e94b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -472,4 +472,9 @@ parameters:
 			count: 1
 			path: src/View/Widget/DateTimeWidget.php
 
+		-
+			message: "#^Class Psy\\\\Shell not found\\.$#"
+			count: 1
+			path: src/basics.php
+
 
diff --git a/src/Cache/Engine/ApcuEngine.php b/src/Cache/Engine/ApcuEngine.php
@@ -140,7 +140,7 @@ public function delete($key): bool
      */
     public function clear(): bool
     {
-        if (class_exists('APCuIterator', false)) {
+        if (class_exists(APCuIterator::class, false)) {
             $iterator = new APCuIterator(
                 '/^' . preg_quote($this->_config['prefix'], '/') . '/',
                 APC_ITER_NONE

diff --git a/src/basics.php b/src/basics.php
@@ -17,6 +17,7 @@
 
 use Cake\Core\Configure;
 use Cake\Error\Debugger;
+use Psy\Shell as PsyShell;
 
 define('SECOND', 1);
 define('MINUTE', 60);
@@ -105,7 +106,7 @@ function stackTrace(array $options = []): void
      */
     function breakpoint(): ?string
     {
-        if ((PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') && class_exists('\Psy\Shell')) {
+        if ((PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') && class_exists(PsyShell::class)) {
             return 'extract(\Psy\Shell::debug(get_defined_vars(), isset($this) ? $this : null));';
         }
         trigger_error(