Merge pull request #14091 from cakephp/fix-deprecated-types

Fixed missing types in api docs

src/Collection/CollectionInterface.php

@@ -257,7 +257,7 @@ public function extract($matcher): CollectionInterface;
      * @param callable|string $callback the callback or column name to use for sorting
      * @param int $type the type of comparison to perform, either SORT_STRING
      * SORT_NUMERIC or SORT_NATURAL
-     * @see \Cake\Collection\CollectionIterface::sortBy()
+     * @see \Cake\Collection\CollectionInterface::sortBy()
      * @return mixed The value of the top element in the collection
      */
     public function max($callback, int $type = \SORT_NUMERIC);

src/Console/CommandCollection.php

@@ -64,7 +64,8 @@ public function add(string $name, $command)
         if (!is_subclass_of($command, Shell::class) && !is_subclass_of($command, CommandInterface::class)) {
             $class = is_string($command) ? $command : get_class($command);
             throw new InvalidArgumentException(sprintf(
-                "Cannot use '%s' for command '%s' it is not a subclass of Cake\Console\Shell or Cake\Console\Command.",
+                "Cannot use '%s' for command '%s'. " .
+                "It is not a subclass of Cake\Console\Shell or Cake\Command\CommandInterface.",
                 $class,
                 $name
             ));

src/Console/Exception/StopException.php

@@ -20,7 +20,7 @@
  *
  * @see \Cake\Console\Shell::_stop()
  * @see \Cake\Console\Shell::error()
- * @see \Cake\Console\Command::abort()
+ * @see \Cake\Command\BaseCommand::abort()
  */
 class StopException extends ConsoleException
 {

src/Database/Query.php

@@ -637,7 +637,7 @@ public function from($tables = [], $overwrite = false)
      * @param array|string $tables list of tables to be joined in the query
      * @param array $types associative array of type names used to bind values to query
      * @param bool $overwrite whether to reset joins with passed list or not
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      * @return $this
      */
     public function join($tables, $types = [], $overwrite = false)
@@ -925,7 +925,7 @@ protected function _makeJoin($table, $conditions, $type): array
      * @param string|array|\Cake\Database\ExpressionInterface|\Closure|null $conditions The conditions to filter on.
      * @param array $types associative array of type names used to bind values to query
      * @param bool $overwrite whether to reset conditions with passed list or not
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      * @see \Cake\Database\Expression\QueryExpression
      * @return $this
      */
@@ -1095,7 +1095,7 @@ public function whereNotInList(string $field, array $values, array $options = []
      * @param string|array|\Cake\Database\ExpressionInterface|\Closure $conditions The conditions to add with AND.
      * @param array $types associative array of type names used to bind values to query
      * @see \Cake\Database\Query::where()
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      * @return $this
      */
     public function andWhere($conditions, array $types = [])

src/View/Form/ArrayContext.php

@@ -290,7 +290,7 @@ public function fieldNames(): array
      *
      * @param string $field A dot separated path to get a schema type for.
      * @return string|null An abstract data type or null.
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      */
     public function type(string $field): ?string
     {

src/View/Form/ContextInterface.php

@@ -100,7 +100,7 @@ public function fieldNames(): array;
      *
      * @param string $field A dot separated path to get a schema type for.
      * @return string|null An abstract data type or null.
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      */
     public function type(string $field): ?string;
 

src/View/Form/EntityContext.php

@@ -691,7 +691,7 @@ protected function _getTable($parts, $fallback = true): ?Table
      *
      * @param string $field A dot separated path to get a schema type for.
      * @return string|null An abstract data type or null.
-     * @see \Cake\Database\Type
+     * @see \Cake\Database\TypeFactory
      */
     public function type(string $field): ?string
     {

tests/TestCase/Console/CommandCollectionTest.php

@@ -61,7 +61,7 @@ public function testConstructor()
     public function testConstructorInvalidClass()
     {
         $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'nope\' it is not a subclass of Cake\Console\Shell');
+        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'nope\'. It is not a subclass of Cake\Console\Shell');
         new CommandCollection([
             'sample' => SampleShell::class,
             'nope' => stdClass::class,
@@ -133,7 +133,7 @@ public function testAddInstance()
     public function testAddInvalidInstance()
     {
         $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'routes\' it is not a subclass of Cake\Console\Shell');
+        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'routes\'. It is not a subclass of Cake\Console\Shell');
         $collection = new CommandCollection();
         $shell = new stdClass();
         $collection->add('routes', $shell);
@@ -179,7 +179,7 @@ public function testAddCommandInvalidName($name)
     public function testInvalidShellClassName()
     {
         $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'routes\' it is not a subclass of Cake\Console\Shell');
+        $this->expectExceptionMessage('Cannot use \'stdClass\' for command \'routes\'. It is not a subclass of Cake\Console\Shell');
         $collection = new CommandCollection();
         $collection->add('routes', stdClass::class);
     }