Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure both node() and afterSave() use ->name
Fixes #1564
- Loading branch information
Fixes #1564
e9011ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not alias in this context?
e9011ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name would be, for example "User" - always. 'Structural' behaviors should always reference the name, not alias property.
You could be referencing the user model as "Author" "Commenter" "Creator" etc. and as such the alias is a variable, and if used in the acl logic it would cause unexpected results (duplicate acl data with the wrong alias, not finding permissions etc.)
e9011ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see. thank you