Split test for required option up

Put the exception based test in its own method.
cakephp · May 5, 2020 · fb2416e · fb2416e
1 parent d9456f3
commit fb2416e
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/tests/TestCase/Console/ConsoleOptionParserTest.php b/tests/TestCase/Console/ConsoleOptionParserTest.php
@@ -333,11 +333,11 @@ public function testAddOptionMultipleOptionsWithMultiple()
     }
 
     /**
-     * test adding a required option.
+     * test adding a required option with a default.
      *
      * @return void
      */
-    public function testAddOptionRequired()
+    public function testAddOptionRequiredDefaultValue()
     {
         $parser = new ConsoleOptionParser('test', false);
         $parser
@@ -359,6 +359,24 @@ public function testAddOptionRequired()
             ['no-default' => 'value', 'help' => false, 'test' => 'default value'],
             $result[0]
         );
+    }
+
+    /**
+     * test adding a required option that is missing.
+     *
+     * @return void
+     */
+    public function testAddOptionRequiredMissing()
+    {
+        $parser = new ConsoleOptionParser('test', false);
+        $parser
+            ->addOption('test', [
+                'default' => 'default value',
+                'required' => true,
+            ])
+            ->addOption('no-default', [
+                'required' => true,
+            ]);
 
         $this->expectException(ConsoleException::class);
         $parser->parse(['--test']);