Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'cake plugin assets copy' doesn't update assets #10151

Closed
1 of 3 tasks
siran opened this issue Feb 2, 2017 · 6 comments
Closed
1 of 3 tasks

'cake plugin assets copy' doesn't update assets #10151

siran opened this issue Feb 2, 2017 · 6 comments
Milestone

Comments

@siran
Copy link
Contributor

siran commented Feb 2, 2017

This is a (multiple allowed):

  • bug

  • enhancement

  • feature-discussion (RFC)

  • CakePHP Version: 3.3.13

  • Platform and Target: doesn't really matter

What you did

I ran $ bin/cake plugin assets copy

What happened

The assets of the plugins whose folders didn't yet existed in webroot/{plugin} were copied, but if the folder of the plugin already existed in webroot the assets weren't updated (or at least a message like ``Copied assets to directory ...` wasn't shown.

What you expected to happen

I expected for all assets to be updated in their corresponding webroot/{plugin} folders

@VarCI-bot
Copy link

siran, please include the CakePHP version number you are using in your description. It helps us debug your issue.

--
Automated response by Var.CI 🤖

@siran
Copy link
Contributor Author

siran commented Feb 2, 2017

updated... updated again, sorry. more details.

@mirko-pagliai
Copy link
Contributor

This is quite difficult and it is for this reason that it is better to make symbolic links and that the copy is only an alternative when you can not create symbolic links.

We should check the correspondence file by file. Or calculate the checksum of the directories and, if they do not match, delete and re-create the copy.

But I repeat: we should use symbolic links in order to avoid all this.

@ADmad
Copy link
Member

ADmad commented Feb 2, 2017

We could add an --overwrite flag.

@ADmad ADmad added this to the Future milestone Feb 2, 2017
@ADmad
Copy link
Member

ADmad commented Feb 9, 2017

@siran Would you like to submit a patch adding the new flag as suggested?

@siran
Copy link
Contributor Author

siran commented Feb 14, 2017

@ADmad I agree with the flag. That is basically what I currently do: "repeal and replace" haha. That can take a while, but I would love to help.
@mirko-pagliai I understand the symbolic link solution. I would use it if the system I'm working had support for it. I currently can't count on mod_rewirte not symbolic links :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants