Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CakeEmail Comma in From address #10763

Closed
1 of 3 tasks
vanbe opened this issue Jun 12, 2017 · 2 comments
Closed
1 of 3 tasks

CakeEmail Comma in From address #10763

vanbe opened this issue Jun 12, 2017 · 2 comments
Assignees
@markstory
Labels
defect
Milestone
2.10.0

Comments

@vanbe
Copy link

vanbe commented Jun 12, 2017 •
edited by AD7six

  • bug

  • enhancement

  • feature-discussion (RFC)

  • CakePHP Version: 2.9.4

  • Platform and Target: CakeEmail -> SMTP Transport

What you did

I'm trying to send and email with a comma in the from_name.

What happened

The sent email is malformed. The MIME enveloppe is not well structured because the comma is not escaped.

Received email header excerpt:

From: "Website, =?UTF-8?B?c3DDqWNpYWxpc3RlIFZPTyI=?= <test@domain.com>
To: test@domain2.com
X-Mailer: CakePHP Email

What you expected to happen

The header should have an extra " :

From: "Website, =?UTF-8?B?c3DDqWNpYWxpc3RlIFZPTw==?=" <test@domain.com>
Otherwise some email readers / gmail, etc are considering that there are multiple From emails due to the non-escaped character.
@markstory markstory added this to the 2.10.0 milestone Jun 12, 2017
@markstory markstory self-assigned this Jun 12, 2017
@markstory
Copy link
Member

Thanks for reporting this. I'll see if I can reproduce it.

markstory added a commit that referenced this issue Jun 13, 2017
@markstory
Fix encoding of addreses containin comma & unicode
738b20a 
Email addresses that contain both unicode and commas will not be
correctly encoded by mime_encode_header if the comma precedes the
unicode. In this scenario we have to quote the encoded address.

Refs #10763
@markstory markstory mentioned this issue Jun 13, 2017
Merged
@markstory
Copy link
Member

Pull request is up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markstory markstory

Labels
defect
Projects
None yet
Milestone
2.10.0
Development

No branches or pull requests
3 participants
@markstory @vanbe @VarCI-bot