SqlserverSchema return colum length double the actual size

[dmromanov]

This is a (multiple allowed):

• bug

• enhancement

• feature-discussion (RFC)

• CakePHP Version: 3.5.3.

• Platform and Target: Windows, MS SQL Server 2012.

What you did

I've created a fixture with a string field having a limit of 50 characters.

// extra columns were truncated
class BakeArticlesFixture extends TestFixture
{
    public $fields = [
        'title' => ['type' => 'string', 'length' => 50, 'null' => false],
    ];
}

What happened

During unit-testing, the table's object reported, that the "title" field has a length of 100 characters.

$schema = $table->getSchema();

What you expected to happen

The length of the field to be reported as 50 characters.

AppVeyor's build log
Affects cakephp/bake/pull/335

[markstory]

This is likely caused by SQLServer telling us that the field is double the length it actually is because SQLServer uses ucs2/utf16 internally. There might not be a way around this.

[dmromanov]

Can't we just divide the value by 2?

[markstory]

Can't we just divide the value by 2?

We could. We'd have to make sure the columns where NVARCHAR / NCHAR and not the standard VARCHAR/CHAR columns as only types with the N prefix have the double length issue.

[markstory]

Closing as there is a pull request open now.