Lazy load models in shells #1147
Conversation
|
Hold up, travis is reporting failures (but passes locally for me). I'll look into and fix it. |
|
@shama what are you doing on the net at this time? go attend the baby :) |
|
@shama travis seems to be broken right now. I don't think the failures are related to your changes. It doesn't even come that far. |
|
@rchavik Luckily this one is a sleepy little guy and letting me out of our cave for a bit :) |
|
@lorenzo ping! This is ready to go. It doesn't add any more travis failures then without the change. Thanks! With this change: https://travis-ci.org/shama/cakephp/builds/5091624 |
| if (empty($this->uses)) { | ||
| return false; | ||
| if (is_array($this->uses)) { | ||
| $this->modelClass = null; |
There was a problem hiding this comment.
modelClass used to be set to uses[0], this same behavior is done in Controller too. It would be good to not set modelClass to null.
|
@markstory Updated to set |
Rebased for 2.4 from the original PR #572 Thanks!