-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename marshall & Marshaller #3045
Comments
Marshal/ler/ing is pretty status-quo. http://en.wikipedia.org/wiki/Marshalling_(computer_science) You stumble across this terminology in other programming languages / ORMs. |
Bah, the method should be marhsal() not marshall() I'll get that fixed up. |
Oh, unless you were strictly speaking about the |
Marshalling was a relatively new term for me too. But it's a pretty standard tech term used in proper context. There's no need for changing it. People can expand their vocabulary 😄 Just fixing the mis-spelling @markstory noticed is enough. |
You need to go for more advanced features in order to find that term inside the public API, hence the |
Blame it to the fact that I'm not an English native speaker but the method name
marshall
and the classMarshaller
do not tell me much.http://api.cakephp.org/3.0/class-Cake.Database.Type.html#_marshall
http://api.cakephp.org/3.0/class-Cake.ORM.Marshaller.html
First things that come to my mind are either a platinum awarded Rap CD or the military...
Even worse when I try to translate the word "marshall" don't get far as the real verb has only one L:
http://dictionary.reference.com/browse/marshal
A method name should speak for itself and as the CakePHP community is not consisted of English native speakers, I think we should rename those two.
Even @lorenzo wasn't very happy from the beginning with:
#2425 (comment)
Unfortunately I have no "more primitive tongue" alternative right now.
Just stumbled upon it and wanted to bring it up.
The text was updated successfully, but these errors were encountered: